Dong/pagination for all intermediary accounts#4752
Dong/pagination for all intermediary accounts#4752czarcas7ic merged 4 commits intoosmosis-labs:mainfrom
Conversation
|
Closing then re-opening this PR to properly trigger CI |
|
Ok. Thank you |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
mattverse
left a comment
mattverse
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM once test case improvised
| res, err := suite.querier.AllIntermediaryAccounts(sdk.WrapSDKContext(suite.Ctx), &types.AllIntermediaryAccountsRequest{}) | ||
| suite.Require().NoError(err) | ||
| suite.Require().Equal(3, len(res.Accounts)) | ||
| suite.Require().Equal(uint64(3), res.Pagination.Total) |
There was a problem hiding this comment.
can we also check the returned values as well?
There was a problem hiding this comment.
I have tested the returned values including ValAddr it is the same address
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
@DongLieu has this change been tested locally? If so and it works, ping me and I will merge. |
czarcas7ic
added
V:state/compatible/no_backport
|
I tested it locally with a test TestAllIntermediaryAccounts(), everything is great |
|
@DongLieu oh no I meant, have you compiled this binary locally and queried mainnet or testnet with this and works as intended |
|
i tried it successfully on testnet |
|
Nice :D |
czarcas7ic
added
V:state/breaking
* Add pagination support for AllIntermediaryAccounts query in Superfluid Module * lint * merge main
5 participants
Closes: #4168
What is the purpose of the change
Add pagination support for AllIntermediaryAccounts query in Superfluid Module
Testing and Verifying
golangci-lint run --fix
Add testcase for AllIntermediaryAccounts