Conversation
mattverse
commented
Sep 15, 2021
ValarDragon
reviewed
Sep 15, 2021
…s/osmosis into mattverse/code-clean
Codecov Report
@@ Coverage Diff @@
## main #481 +/- ##
==========================================
- Coverage 20.41% 20.40% -0.02%
==========================================
Files 163 163
Lines 23206 23209 +3
==========================================
- Hits 4738 4736 -2
- Misses 17694 17698 +4
- Partials 774 775 +1
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Sep 20, 2021
ValarDragon
reviewed
Sep 20, 2021
ValarDragon
reviewed
Sep 20, 2021
ValarDragon
reviewed
Sep 20, 2021
ValarDragon
reviewed
Sep 20, 2021
Member
|
LGTM other than claims parameter and simulation log line! |
ValarDragon
reviewed
Oct 5, 2021
ValarDragon
reviewed
Oct 5, 2021
ValarDragon
reviewed
Oct 5, 2021
ValarDragon
reviewed
Oct 5, 2021
ValarDragon
reviewed
Oct 6, 2021
ValarDragon
reviewed
Oct 6, 2021
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
ValarDragon
reviewed
Oct 6, 2021
ValarDragon
reviewed
Oct 6, 2021
ValarDragon
approved these changes
Oct 6, 2021
Member
ValarDragon
left a comment
ValarDragon
left a comment
There was a problem hiding this comment.
LGTM now. Made a commit with the remaining deletes we talked about. Can you merge after having a look?
ValarDragon
reviewed
Oct 7, 2021
Contributor
Author
|
Srry my bad, thought I did a final check on everything to confirm they are all good :( |
giansalex
reviewed
Dec 4, 2021
| return err | ||
| } | ||
|
|
||
| if data.DistrInfo.TotalWeight.LT(sdk.NewInt(0)) { |
Contributor
There was a problem hiding this comment.
default DistrInfo value is nil, this throw an error:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1358cdc]
goroutine 1 [running]:
github.com/osmosis-labs/osmosis/x/pool-incentives/types.ValidateGenesis(0xc00048a4b0)
github.com/osmosis-labs/osmosis/x/pool-incentives/types/genesis.go:53 +0x7c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Cleaning code!