fix(x/twap): genesis issue blocking edge net set up#5129
Merged
Conversation
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2023
* fix(x/twap): genesis issue blocking edge net set up * changelog * comment (cherry picked from commit a131abf) # Conflicts: # CHANGELOG.md
p0mvn
added a commit
that referenced
this pull request
May 9, 2023
p0mvn
added a commit
that referenced
this pull request
May 9, 2023
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* fix(x/twap): genesis issue blocking edge net set up * changelog * comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5041
What is the purpose of the change
More context: https://osmosis-network.slack.com/archives/C027ELA290B/p1682692206195569
Currently, our validation for
TwapRecords inInitGenesis()is stricter than it should be.If there is a twap error, it expects both "p0" spot price and "p1" spot price to be zero.
However, that is not the guarantee from the core logic:
osmosis/x/twap/logic.go
Lines 53 to 64 in b101d06
In the core logic above, if "p0" gets a twap error but "p1" does not, "p0" is set to zero but "p1" isn't.
Therefore, we should change our init genesis logic to match the core's constraints.
Brief Changelog
Testing and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no