Merged
Conversation
p0mvn
approved these changes
May 23, 2023
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* multiple fee tokens gov prop * update changelog * add cli example line --------- Co-authored-by: Roman <roman@osmosis.team>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR changes
UpdateFeeTokenProposalto take multiple fee tokens as an argument. We previously would have to make a new gov proposal for each fee token we wanted to add, which creates too much noise for what is trying to be achieved.Testing and Verifying
Existing tests modified to take in new array
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)