Pool Incentives: Allow Zero Weight

[jeebster]

Closes: #546

Description

Validation check for pool-incentive gauge weight will only throw for negative values

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

[ValarDragon]

LGTM! Just checked in

osmosis/x/pool-incentives/keeper/distr.go

Line 154 in ea6bda7

func (k Keeper) UpdateDistrRecords(ctx sdk.Context, records ...types.DistrRecord) error {

, the Update function already correctly handles zero weights, so we should be set.

Thanks for fixing this =)

[ValarDragon]

The lint issue seems unrelated, something broke on main 😕

[codecov-commenter]

Codecov Report

Merging #563 (55fe26c) into main (a2bd530) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   20.31%   20.31%           
=======================================
  Files         164      164           
  Lines       23262    23262           
=======================================
  Hits         4726     4726           
  Misses      17762    17762           
  Partials      774      774           

Impacted Files	Coverage Δ
x/pool-incentives/types/record.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bd530...55fe26c. Read the comment docs.