Distribution, expand the ignored distributios set#7250
Merged
czarcas7ic merged 8 commits intomainfrom Feb 10, 2024
Merged
Conversation
czarcas7ic
approved these changes
Jan 7, 2024
| return true, totalDistrCoins, err | ||
| } | ||
|
|
||
| // Remove some spam gauges that are not worth distributing. (We ignore the denom stake because of tests.) |
Member
There was a problem hiding this comment.
(We ignore the denom stake because of tests.)
LOL, cant we just inc the tests to be greater than 100??
mattverse
approved these changes
Jan 8, 2024
| return totalDistrCoins, err | ||
| } | ||
|
|
||
| func (k Keeper) skipSpamGaugeDistribute(ctx sdk.Context, locks []*lockuptypes.PeriodLock, gauge types.Gauge, totalDistrCoins sdk.Coins, remainCoins sdk.Coins) (bool, sdk.Coins, error) { |
Contributor
There was a problem hiding this comment.
I think it'd be worth creating unit test for this as well
Contributor
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the set of gauges we ignore, as we are now no longer concerned about state compat in main.
This changes
to
Requiring a gauge to distribute at least 100 coins, for any pool. Ignores "stake" to avoid fixing all the tests.