Skip to content

fix: superfluid log for error that should be ignored #8791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValarDragon merged 2 commits into from
Oct 30, 2024
Merged

fix: superfluid log for error that should be ignored #8791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dcde5b
fix: superfluid log for error that should be ignored
PaddyMc Oct 30, 2024
cdc98b0
chore: changelog update
PaddyMc Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* [#8765, 8768](https://github.com/osmosis-labs/osmosis/pull/8765) fix concurrency issue in go test(x/lockup)
* [#8563](https://github.com/osmosis-labs/osmosis/pull/8755) [x/concentratedliquidity]: Fix Incorrect Event Emission
* [#8765](https://github.com/osmosis-labs/osmosis/pull/8765) fix concurrency issue in go test(x/lockup)
* [#8791](https://github.com/osmosis-labs/osmosis/pull/8791) fix: superfluid log for error that should be ignored

### State Machine Breaking

Expand Down
6 changes: 6 additions & 0 deletions x/superfluid/keeper/epoch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"

distributiontypes "github.com/cosmos/cosmos-sdk/x/distribution/types"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"

"github.com/osmosis-labs/osmosis/osmoutils"
cl "github.com/osmosis-labs/osmosis/v26/x/concentrated-liquidity"
Expand Down Expand Up @@ -80,6 +81,11 @@ func (k Keeper) MoveSuperfluidDelegationRewardToGauges(ctx sdk.Context, accs []t
ctx.Logger().Debug("no delegations for this (pool, validator) pair, skipping...")
// TODO: Remove this account from IntermediaryAccounts that we iterate over
return nil
} else if errors.Is(err, stakingtypes.ErrNoDelegation) {
// NOTE: in v0.50.x the function changed to return a different error
ctx.Logger().Debug("no delegations for this (pool, validator) pair, skipping...")
// TODO: Remove this account from IntermediaryAccounts that we iterate over
return nil
} else if err != nil {
return err
}
Expand Down