Upgrade IAVL and SDK with RAM improvements and bug fixes for v6.4#907
Merged
ValarDragon merged 5 commits intov6.xfrom Feb 21, 2022
Merged
Upgrade IAVL and SDK with RAM improvements and bug fixes for v6.4#907ValarDragon merged 5 commits intov6.xfrom
ValarDragon merged 5 commits intov6.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## v6.x #907 +/- ##
=======================================
Coverage 19.06% 19.06%
=======================================
Files 167 167
Lines 23684 23684
=======================================
Hits 4516 4516
Misses 18387 18387
Partials 781 781 Continue to review full report at Codecov.
|
p0mvn
changed the title
p0mvn
changed the title
ValarDragon
reviewed
Feb 20, 2022
ValarDragon
reviewed
Feb 20, 2022
ValarDragon
approved these changes
Feb 20, 2022
Member
ValarDragon
left a comment
ValarDragon
left a comment
There was a problem hiding this comment.
LGTM once two minor comments are in!
ValarDragon
reviewed
Feb 20, 2022
p0mvn
changed the title
4 tasks
ValarDragon
reviewed
Feb 20, 2022
CHANGELOG.md
Outdated
|
|
||
| ### SDK fork updates | ||
|
|
||
| - [sdk-#114](https://github.com/osmosis-labs/cosmos-sdk/pull/114) [commit](https://github.com/osmosis-labs/cosmos-sdk/pull/114/commits/7ec05684856bf87b868f67d05459d64931ac599d) upgrading iavl with ram optimizations during migration and extra logs |
Member
There was a problem hiding this comment.
Ah sorry I didn't click through to the PR before, didn't realize its the bug fix. So then we just need to update this log message.
Suggested change
| - [sdk-#114](https://github.com/osmosis-labs/cosmos-sdk/pull/114) [commit](https://github.com/osmosis-labs/cosmos-sdk/pull/114/commits/7ec05684856bf87b868f67d05459d64931ac599d) upgrading iavl with ram optimizations during migration and extra logs | |
| - [sdk-#114](https://github.com/osmosis-labs/cosmos-sdk/pull/114) upgrading iavl with ram optimizations during migration and extra logs | |
| - [commit](https://github.com/osmosis-labs/cosmos-sdk/pull/114/commits/7ec05684856bf87b868f67d05459d64931ac599d) Fix the bug when a node crashes during commit, and runs into non-logical commit issues. |
This was referenced Apr 15, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
The main focus of this upgrade is stability improvements with the IAVL patch of v0.44.3x-osmo-v5.1. The big points are:
The bugs people were seeing for nodes being saved to a different hash, etc. happen after restoring the node post-crash during commit (the crash could be caused by something else). The bug on restart stems from the long-standing issue that SDK commits are actually not-atomic. This manifested in a failure to flush the latest height when an error during commit occurs, causing the state invalidities on restart. We mitigated the non-atomicity problem by flushing the metadata about the stores that successfully committed a new height. As a result, on restart, the SDK now knows which stores/modules are already on the newly committed height.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer