Skip to content

πŸ‘©β€πŸŒΎ [backport] [foxy] Update cmake minimum version to 2.8.12 (#61)#63

Merged
wjwwood merged 2 commits intofoxyfrom
chapulina/foxy/61
Apr 26, 2021
Merged

πŸ‘©β€πŸŒΎ [backport] [foxy] Update cmake minimum version to 2.8.12 (#61)#63
wjwwood merged 2 commits intofoxyfrom
chapulina/foxy/61

Conversation

@chapulina
Copy link
Copy Markdown

Backporting #61 to fix the warning on Foxy.


https://github.com/osrf/buildfarmer/issues/181

* Update cmake minimum version to 2.8.12

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Try setting policy explicitly

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Trying this

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Manually patching archive

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@chapulina chapulina added the Windows Windows support label Apr 21, 2021
@chapulina
Copy link
Copy Markdown
Author

I'll trigger CI after Jenkins is reset at ci.ros2.org

@chapulina
Copy link
Copy Markdown
Author

CI is running, I used a repos file generated with make_repos_gist and it's testing up to rcutils like the original PR.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@chapulina
Copy link
Copy Markdown
Author

The farm was in a bad state yesterday. New run:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Apr 22, 2021

CI again since the cyclonedds issue was resolved:

  • Linux Build Status
  • Linux-aarch64 Build Status (cmake warning from connext, seems unrelated)
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Copy Markdown
Author

Also needed a fix from #55, done in 1ff09bc.

New round of CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@chapulina
Copy link
Copy Markdown
Author

Oh look at that, not only this warning is gone, but all other Windows warnings are gone too πŸ€” Fishy 🐟

It looks like it did what this PR was set to do:

18:28:17 -- googletest version '1.10.0.1' selected, of versions: '1.8.1;1.10.0.1'
18:28:17 -- building googletest from 'C:/ci/ws/src/osrf/osrf_testing_tools_cpp/osrf_testing_tools_cpp/vendor/google/googletest/release-1.10.0.1.tar.gz'...

@wjwwood wjwwood merged commit 888cc03 into foxy Apr 26, 2021
@wjwwood wjwwood deleted the chapulina/foxy/61 branch April 26, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Windows Windows support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants