Closed
Conversation
|
Hi, I found a critical optimization bug in your pathfinding implementation. |
Contributor
Author
bot |
I already contacted you via Messenger, but the message may be in your spam requests. |
Contributor
Author
|
I found the last bug now that references are done correctly. I will push the update soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Modify when we incrementReferenceCounter and decrement for followers.
Issues addressed:
Possibly #4961 and fix crashed @MillhioreBT mentioned.
How to test:
The best way is to test with one monster and std::cout the monsters references count. It should +-1 as you add and remove it as a follower. You can run far away, log out, ect. It should log a +-1. To test crashes just run out, kill, and remove multiple monsters.