AO3-5696 fix orphan account chapter subscription emails#5758
Open
pmonfort wants to merge 2 commits intootwcode:masterfrom
Open
AO3-5696 fix orphan account chapter subscription emails#5758pmonfort wants to merge 2 commits intootwcode:masterfrom
pmonfort wants to merge 2 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5696
Purpose
When
orphan_accountis a co-creator on a multi-chapter work and another co-creator posts a new chapter without listingorphan_account, users subscribed toorphan_accountincorrectly receive subscription emails.The existing check in
Subscription#valid_notification_entry?only inspects the creation's (chapter's) pseuds, missing the case whereorphan_accountis a co-creator at the work level but not on the individual chapter.Added a guard that skips notifications when the subscription is to
orphan_accountdirectly. Subscribers of other co-creators on the same work are not affected.Testing Instructions
orphan_accountorphan_accountas co-creatororphan_accountas chapter co-creatorbundle exec rake notifications:deliver_subscriptionsorphan_accountReferences
Related to AO3-3620 (Allow subscriptions to orphan_account to receive notifications). When AO3-3620 is fixed, the two
User.orphan_accountguards invalid_notification_entry?should be removed.Credit
Pablo Monfort (he/him)