fix!: Migrate to STORAGES from DEFAULT_FILE_STORAGE#65
Merged
Danyal-Faheem merged 1 commit intomainfrom Sep 18, 2025
Merged
Conversation
rehmansheikh222
requested review from
Danyal-Faheem,
DawoudSheraz and
ahmed-arb
Danyal-Faheem
suggested changes
Sep 16, 2025
Contributor
Danyal-Faheem
left a comment
Danyal-Faheem
left a comment
There was a problem hiding this comment.
Can you also add a changelog entry signifying that this is a breaking change?
nit: Lets also add a detailed commit message signifying that this is a breaking change and a better PR description
Contributor
+1 to these comments. The commit should also mention that this is a breaking change (fix!) |
rehmansheikh222
changed the title
rehmansheikh222
force-pushed
the
rehman/migrate-to-storages
branch
from
33c57e2 to
a8c381d
Compare
Danyal-Faheem
suggested changes
Sep 17, 2025
changelog.d/20250917_111934_abdul.rehman02_migrate_to_storages.md
Outdated
Show resolved
Hide resolved
rehmansheikh222
force-pushed
the
rehman/migrate-to-storages
branch
from
a8c381d to
0fe1488
Compare
DawoudSheraz
approved these changes
Sep 18, 2025
Danyal-Faheem
approved these changes
Sep 18, 2025
github-project-automation
bot
moved this from In review
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #63
This is a breaking change as we are migrating from using DEFAULT_FILE_STORAGE to STORAGES as the same migration has been made in the edx-platform repo https://github.com/openedx/edx-platform/pull/37002/files