feat: migrate to Meilisearch - #40
Merged
Merged
Conversation
DawoudSheraz
approved these changes
Oct 18, 2024
jfavellar90
approved these changes
Oct 21, 2024
Collaborator
|
@regisb I approved this PR, however, I would like to ask if the PR openedx/edx-notes-api#444 should be pushed so it's included in the Sumac cutoff. |
Notes directory could be added via `tutor mounts add ./edx-notes-api`, but it was not actually being mounted.
We make use of a new search engine to search annotations. The index will automatically be created and filled during init. This is considered a breaking change if you have customised your notes index.
jfavellar90
force-pushed
the
regisb/meilisearch
branch
from
October 24, 2024 14:02
658f46f to
0a08554
Compare
Collaborator
|
@regisb I rebased your branch on top of Sumac branch and changed the PR base branch to Sumac. |
Contributor
|
I did a quick test with core sumac branch (meilisearch has been merged), and the feature is working as expected. I am merging this PR so that it becomes available in sumac sandbox over the next build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make use of a new search engine to search annotations. The index will
automatically be created and filled during init. This is considered a
breaking change if you have customised your notes index.
Note that this branch should actually be merged in the "sumac" branch, not nightly. This is pending on the creation of the "sumac" branch.
Here's the corresponding upstream PR: openedx/edx-notes-api#444