Disable open_basedir on Ubuntu 20.04#140
Closed
phil-davis wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I am not really familiar with the way all this overlay stuff works. Is this the right way to change a |
Contributor
Author
|
Still digging into this - this may not be required. |
Contributor
Author
|
The unit test problem is something different - closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/owncloud/core/blob/master/lib/private/LargeFileHelper.php#L115
getFileSizeViaCurl()requires thatopen_basediris not set (is the empty string).In Ubuntu 20.04 with PHP 7.4
php.inisets it by default. That causes some unit tests to fail in owncloud/core#39460:This PR sets
open_basedirto the empty string, like it was in Ubuntu 18.04.