Skip to content

feat: add php on ubuntu 22.04#148

Merged
phil-davis merged 2 commits into
masterfrom
php-on-22.04
Jun 7, 2022
Merged

feat: add php on ubuntu 22.04#148
phil-davis merged 2 commits into
masterfrom
php-on-22.04

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

This adds an image that has Ubuntu 22.04 with PHP 7.4 installed. That will be useful for testing oC10.10 and later to verify that automated tests are all passing.

@phil-davis phil-davis self-assigned this Jun 7, 2022
@phil-davis
phil-davis marked this pull request as ready for review June 7, 2022 09:25
@phil-davis
phil-davis requested a review from xoxys June 7, 2022 09:26
@phil-davis

Copy link
Copy Markdown
Contributor Author

It passed CI the first time - that makes me suspicious, it can't be that easy? @xoxys

@xoxys

xoxys commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Don't know, would need testing I guess.

@phil-davis

phil-davis commented Jun 7, 2022

Copy link
Copy Markdown
Contributor Author

Don't know, would need testing I guess.

The CI looks good - it did actually run what I expected.
I guess I should merge this. Then I can use it and see if there are any problems...

@phil-davis
phil-davis merged commit 32c709b into master Jun 7, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the php-on-22.04 branch June 7, 2022 09:59
@phil-davis

Copy link
Copy Markdown
Contributor Author

Merge CI https://drone.owncloud.com/owncloud-ci/php/553 passed. This should be published now - I will try to use it.

@phil-davis

Copy link
Copy Markdown
Contributor Author

working in owncloud/core#40123 - there are some unit test failures unexpectedly with files_external. But I will follow that up in that core PR. If it turns out to be some settings/extension thing then I might be back to this repo to tweak something, or maybe the oC10 source code needs to be improved or...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants