Reorganize 7.4 - #155
Merged
Merged
Conversation
xoxys
approved these changes
Oct 12, 2022
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7.4tov7.4-ubuntu18.04and adjust - anything that explicitly wants to test with Ubuntu 18 (LTS) will now need to specifyv7.4-ubuntu18.04v7.4-ubuntu20.04tov7.4and adjust.v7.4will now provide a PHP 7.4 environment running on top of Ubuntu 20.04Nowadays we are recommending Ubuntu 20.04 anyway, and the latest Ubuntu 20.04 docker image has the
setprivcommand, which is needed to replace any uses ofsu-execwhich is gone. So we can use PHP 7.4 with Ubuntu 20.04 for all the regular drone CI core and apps pipelines.core is already using
7.4-ubuntu20.04. Activity app passes with that, and we refactored CI of the wopi app yesterday to fix a problem, and had to use 7.4-ubuntu20.04. So it seems time for that to be the default.