Skip to content

Reduce the number of 4000chars columns#512

Closed
nickvergessen wants to merge 1 commit into
masterfrom
core-17978-mysql-4byte
Closed

Reduce the number of 4000chars columns#512
nickvergessen wants to merge 1 commit into
masterfrom
core-17978-mysql-4byte

Conversation

@nickvergessen

Copy link
Copy Markdown
Contributor

@DeepDiver1975 for the MySQL 4byte work.
Does text(4000) to clob work on all dbms?

@mention-bot

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @karlitschek, @libasys and @fossxplorer to be potential reviewers

@DeepDiver1975

Copy link
Copy Markdown
Member

Does text(4000) to clob work on all dbms?

We have to test this

@nickvergessen

Copy link
Copy Markdown
Contributor Author

Okay, will try to add one in core.

@LukasReschke

LukasReschke commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

I guess @butonic won't like you for that: owncloud/core#23895 (comment) 😉

@butonic Thoughts?

@butonic

butonic commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

👎 find a better solution for oracle first

@nickvergessen

Copy link
Copy Markdown
Contributor Author

Just saying in the activity app we never sort, search or whatever with these columns, only select via * is done.

@DeepDiver1975

Copy link
Copy Markdown
Member

Using clob is valid from my pov - but the migration is tricky.
We also have to take into account that the activity table is hugh on some installations .....

@karlitschek

Copy link
Copy Markdown

This will make the upgrade from 9.0 to 9.1 slow. I'm not saying that we can't do that but we have to be careful.
I also agree with @DeepDiver1975 and @butonic that this needs proper testing. Experience shows that there is a lot that can go wrong in corner-cases.

@nickvergessen

Copy link
Copy Markdown
Contributor Author

So do we do this now, or one more version until people with 4byte mysql can use activity app?

@nickvergessen nickvergessen modified the milestones: 9.2-next, 9.1-current Jun 1, 2016
@nickvergessen

Copy link
Copy Markdown
Contributor Author

Oracle is unable to convert from text to clob atm, see owncloud/core#24897
So if we don't want people to run some commands manually for the time-being, there is no way to do that.

@DeepDiver1975
DeepDiver1975 deleted the core-17978-mysql-4byte branch November 22, 2016 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants