Adapt "public link" permissions to oC server 10.0.4 UI

[michaelstingl]

UI for "public link" permissions has been improved with oC server 10.0.4:
owncloud/core#29376

@davigonz What is the effort to bring this to the Android client?

[davigonz]

@michaelstingl

I really like the new distribution of sharing permissions in core, it is much clearer for the user.

What is the effort to bring this to the Android client?

Well, in terms of UI, we just have to replace the two switch buttons (Allow editing & Show file listing) with a new dropdown menu, or something like that, which includes the new three options. I will create a mockup.

In terms of logic, it shouldn't take too much because we just have to move the same functionality from two buttons to a list with three options.

So, to sum up, I would say that is easy to implement, one or two days at most.

[theScrabi]

This is how it will look like

[michaelstingl]

@pmaier1 ^

[jesmrec]

The links to files has also included the "Read Only" option:

will we include in the scope of this issue, or create a separate one? @theScrabi @davigonz

[theScrabi]

I think this should be in scope of this. However I think this option is not working on server side because it looks like a radio button and it behaves like one, tho it should be a checkbox. This is why clicking on it has no action.

Maybe it's not intended to make a single file share writable.

[jesmrec]

let's check with core to take a decision.

[pmaier1]

Here is the final wording as it's released with Server 10.0.8 https://github.com/owncloud/enterprise/issues/2184#issuecomment-379206490. Please use that.

[pmaier1]

However I think this option is not working on server side because it looks like a radio button and it behaves like one, tho it should be a checkbox

Just to clarify: It works as expected and should not be a checkbox as it's the only available permission currently for public links on single files. The other permissions are only available for folders.
We will add read/write permission to the server at some point but not yet scheduled. Clients should adapt to that when it's available.