#296: Add documents provider

[przybylski]

--------- edited by @jabarros
TASKs:

• [QA] Create 'document_provider' branch in QA Repo @jesmrec
• [QA] Merge 'document_provider' branch in QA Repo
• [QA] Create test plan @jesmrec
• [QA] Validate test plan @jesmrec

---

[tobiasKaminsky]

Have you tested it?
Then I can do a code review and add it in beta?

[przybylski]

works fine with multiple accounts, on nexus 4

[tobiasKaminsky]

Maybe this would be a good use case to show it in the "what's new" slide show?

[tobiasKaminsky]

Included in beta.
Please test @ALL

[przybylski]

could be, but 'whats new' should be also included, this requires some addtional work from graphics people

[tobiasKaminsky]

Yeah, then we should enforce this...
Who is responsible for the artwork?

[przybylski]

No idea :D @AndyScherzinger said that he would take a look on images and texts

[tobiasKaminsky]

@przybylski
#296 (comment) said:
The beta client seems to support opening via SAF, but not saving.

[przybylski]

I know, for now I want to provide opening, saving will come in other PR

[tobiasKaminsky]

@przybylski the current version shows only downloaded files, right?
It would be cool to have every file on the server and download them if necessary?
Or is it possible to show the download state to the user?

[przybylski]

Last time I tested it, it was working just as you described it. Showing all the files and download then if necessary

[tobiasKaminsky]

Maybe I have messed something up in beta.
Can you try it there?

[przybylski]

The code looks fine on beta branch. Is it not downloading the file?
Currently my android device is far away from me so I cannot test it on the real data :/
The one confusing thing is that there will be no progress indicator on the activity but on the notification bar. But this is something that system is forcing so there si nothing we can do about it.

[tobiasKaminsky]

The files / folders that are not already downloaded are not even shown, so I cannot click them.

[przybylski]

Ok, I can see the problem,
when you were rebasing for beta branch you updated getFolderContent call to include true flag (only on device), it should be false on beta.

[tobiasKaminsky]

Thanks :)
Now it is working! I will add it to beta soon.

Is it possible to show the download state?

[przybylski]

No, DocumentProvider doesn't support progress indicator. The only download state is available in a notification bar, and it is normally invoked when ownCloud is downloading file..

[tobiasKaminsky]

Ah, no, I meant the state of a file: downloaded on device / not downloaded.
As it might be interesting to see this in order to avoid triggering a big download when selecting a file.

[przybylski]

There is no built in mechanism in DocumentsProvider to indicate this :/

[malkomich]

Is it necessary to make this existing Provider public?

[przybylski]

yes, documents provider is queried by external application, and at that point its outside owncloud permission so exported content provider is required.

[davivel]

Hi, @przybylski .

Should we understand you don't want to contribute this code to ownCloud anymore?

Thanks in advance.

[przybylski]

It's not that I don't want to, but the fact that such simple pr was opened for over half a year got me discouraged.

[davivel]

I can understand that. In any case, closing it doesn't seem a way to get it merged faster, does it?

Please, consider reopening it. Your contributions to this project always were more than important.

[przybylski]

It didn't got it faster, BUT it got your attention so it kinda worked ;)

[jabarros]

@jesmrec this PR is prepared to be tested :)
@przybylski maybe a rebase on master is needed in order to have the branch updated. Could you do that?

[jesmrec]

👍 @jabarros a test plan will be designed asap.

[jabarros]

@jesmrec, rebase on master done

[jesmrec]

Approved, nice work. Next step, ability to modify :) :)

@przybylski @jabarros A new rebase is needed, please.

[jabarros]

Rebase done. Wating Travis.