[DC-158] chore: remove ownCloud 10 update channel #12429
+38
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
modSpike
reviewed
Dec 15, 2025
modSpike
reviewed
Dec 15, 2025
erikjv
reviewed
Jan 23, 2026
modSpike
reviewed
Jan 26, 2026
modSpike
reviewed
Jan 26, 2026
modSpike
reviewed
Jan 26, 2026
src/libsync/configfile.cpp
Outdated
| const QString skipUpdateCheckC() { return QStringLiteral("skipUpdateCheck"); } | ||
| const QString updateCheckIntervalC() { return QStringLiteral("updateCheckInterval"); } | ||
| const QString updateChannelC() { return QStringLiteral("updateChannel"); } | ||
| // deprecated - will be removed in 8.0 |
Contributor
There was a problem hiding this comment.
don't just comment it out - we should keep compiler warnings. to "properly" deprecate:
[[deprecated("updateChannel is no longer supported. the key will be removed in 8.0")]] const QString updateChannelC()....
the todo item for these is #52 so I am currently tagging any deprecations with // todo: #52 remove with next major release
modSpike
reviewed
Jan 26, 2026
| // remove deprecated updateChannel setting once we hit 8.0 | ||
| auto settings = ConfigFile::makeQSettings(); | ||
| QString updateChannelKey = "updateChannel"; | ||
| /* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.