Conversation
QByteArray is used for checksum
Contributor
Author
|
( extracted from #5056 ) |
Contributor
|
👍 Maybe we should remove the default case and error log so that we notice next time in case we introduce a new data type. |
Contributor
|
Why not use sqlite3_bind_blob ? |
Contributor
Author
I don't know? Why use it? Currently all the QByteArray only contains text. |
Contributor
|
OK 👍 if you take the risk that if we ever change that something bad happens. |
Contributor
Author
|
Any other than a string was not working before because we were converting to QString anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QByteArray is used for checksum