Private links: Retrieve link through propfind property #6020#6037
Merged
Conversation
9 tasks
ogoffart
previously requested changes
Sep 18, 2017
| void SocketApi::command_COPY_PRIVATE_LINK(const QString &localFile, SocketListener *) | ||
| // Fetches the private link url asynchronously and then calls the target slot | ||
| template <typename T> | ||
| void fetchPrivateLinkUrl(const QString &localFile, typename QtPrivate::FunctionPointer<T>::Object *target, |
Contributor
There was a problem hiding this comment.
Don't use QtPrivate, this is not Qt public API and it might be changed.
Just use SocketApi* or another template type.
(maybe no need to have a template: void fetchPrivateLinkUrl(const QString &localFile, SocketApi *target, void (SocketApi::*targetFunc)() )
ckamm
force-pushed
the
privatelinkproperty
branch
from
156d65a to
e3953c3
Compare
* The sharing ui does a propfind anyway: use that to query the new property as well! * For the socket api, asynchronously query the server for the right url when an action that needs it is triggered. The old, manually generated URL will be used as fallback in case the server doesn't support the new property or the property can't be retrieved for some reason. Depends on owncloud/core#29021
ckamm
force-pushed
the
privatelinkproperty
branch
from
e3953c3 to
3f56cb0
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
property as well!
when an action that needs it is triggered.
The old, manually generated URL will be used as fallback in case the
server doesn't support the new property or the property can't be
retrieved for some reason.
Depends on owncloud/core#29021
For #6020