zsync: use larger rolling hash size to avoid conflicts - #6390
Merged
Conversation
ckamm
changed the title
ckamm
force-pushed
the
delta-zsync-rolling-hash
branch
from
March 16, 2018 09:54
15aff7b to
50b8d1c
Compare
Contributor
Author
|
The zsync PR has to merge before this PR can be updated and merged. |
ogoffart
reviewed
Mar 16, 2018
ogoffart
left a comment
ogoffart
left a comment
Contributor
There was a problem hiding this comment.
So if i understand correctly, that means there is an incompatible change in zsync?
Contributor
Author
|
This PR only works in conjunction with my zsync patch. So the steps are
|
Contributor
|
zsync PR merged. Thanks @ckamm for putting all this work in, great to know this is all in capable hands! |
ckamm
force-pushed
the
delta-zsync-rolling-hash
branch
from
March 16, 2018 12:28
50b8d1c to
97d31bb
Compare
Contributor
Author
|
This PR needs to be rebased onto delta-sync and the zsync submodule sha1 needs to be updated once ahmedammar/zsync#3 is merged |
ckamm
force-pushed
the
delta-zsync-rolling-hash
branch
from
March 23, 2018 07:00
97d31bb to
307b79d
Compare
* Only in cpp files * Include early (on windows, winsock2.h should go before windows.h)
ckamm
force-pushed
the
delta-zsync-rolling-hash
branch
from
March 26, 2018 09:35
5f1d2e4 to
2f17f37
Compare
Contributor
Author
|
@ogoffart @ahmedammar All is now in order and jenkins passes - does this look good to you? |
Contributor
|
Looks great! I've been following your commits, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #6389 and has only one commit 15aff7b. It also depends on ahmedammar/zsync#2
@ahmedammar