Sharing: Fix fast share creation with enforced expiry and 10.2.0#7249
Merged
Conversation
Fixes the "Copy public link to clipboard" context menu action for newer servers. Previously the server would fill the expiration date for us, since version 10.2.0 it reports an error. To workaround that the action now always sends an expiration date if default expiration is enabled in the settings. For #7245
ckamm
force-pushed
the
7245-linkshare-autocreate-with-expiry
branch
from
01d5bd9 to
60fa7ea
Compare
ogoffart
approved these changes
Jun 18, 2019
ogoffart
left a comment
ogoffart
left a comment
Contributor
There was a problem hiding this comment.
But this shows a bug on the server, that change of behavior will break with old client and this isn't good.
Is there an issue open on the server for this?
Contributor
Author
|
@ogoffart Yeah: owncloud/core#35564 |
delete-merged-branch
Bot
deleted the
7245-linkshare-autocreate-with-expiry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "Copy public link to clipboard" context menu action for newer
servers.
Previously the server would fill the expiration date for us, since
version 10.2.0 it reports an error. To workaround that the action now
always sends an expiration date if default expiration is enabled in
the settings.
For #7245