Share with group, rename as recipient, then share with user directly => double folder

[PVince81]

The fix for #24575 on master is not enough 😦

Steps

1. Admin shares "test" with "group1" and "group2" (user1 is member of both)
2. "user1" renames "test" to "test_renamed"
3. admin now shares "test" directly with "user1"

Expected

Received share is still called "test_renamed" (8.2 behavior)

+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+
| id | share_type | share_with | uid_owner | parent | item_type | item_source | item_target | file_source | file_target   | permissions | stime      | accepted | expiration | token | mail_send | uid_initiator |
+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+
|  6 |          1 | group1     | admin     |   NULL | folder    | 9           | NULL        |           9 | /test         |          31 | 1469167795 |        0 | NULL       | NULL  |         0 | admin         |
|  7 |          1 | group2     | admin     |   NULL | folder    | 9           | NULL        |           9 | /test         |          31 | 1469167798 |        0 | NULL       | NULL  |         0 | admin         |
|  8 |          2 | user1      | admin     |      6 | folder    | 9           | NULL        |           9 | /test_renamed |          31 | 1469167795 |        0 | NULL       | NULL  |         0 | NULL          |
|  9 |          2 | user1      | admin     |      7 | folder    | 9           | NULL        |           9 | /test_renamed |          31 | 1469167798 |        0 | NULL       | NULL  |         0 | NULL          |
| 10 |          0 | user1      | admin     |   NULL | folder    | 9           | NULL        |           9 | /test_renamed |          31 | 1469167819 |        0 | NULL       | NULL  |         0 | admin         |
+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+

Actual

Two folders, "test" and "test_renamed"

+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+
| id | share_type | share_with | uid_owner | parent | item_type | item_source | item_target | file_source | file_target   | permissions | stime      | accepted | expiration | token | mail_send | uid_initiator |
+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+
|  6 |          1 | group1     | admin     |   NULL | folder    | 9           | NULL        |           9 | /test         |          31 | 1469167795 |        0 | NULL       | NULL  |         0 | admin         |
|  7 |          1 | group2     | admin     |   NULL | folder    | 9           | NULL        |           9 | /test         |          31 | 1469167798 |        0 | NULL       | NULL  |         0 | admin         |
|  8 |          2 | user1      | admin     |      6 | folder    | 9           | NULL        |           9 | /test_renamed |          31 | 1469167795 |        0 | NULL       | NULL  |         0 | NULL          |
|  9 |          2 | user1      | admin     |      7 | folder    | 9           | NULL        |           9 | /test_renamed |          31 | 1469167798 |        0 | NULL       | NULL  |         0 | NULL          |
| 10 |          0 | user1      | admin     |   NULL | folder    | 9           | NULL        |           9 | /test         |          31 | 1469167819 |        0 | NULL       | NULL  |         0 | admin         |
+----+------------+------------+-----------+--------+-----------+-------------+-------------+-------------+---------------+-------------+------------+----------+------------+-------+-----------+---------------+

On master and stable9.1-group_shares

@owncloud/sharing

[NacreData]

Research related issues and the many, many baffled user posts on many forums leads me to conclude that the way ownCloud allows users to rename files and folders is clearly a mis-feature with more unintended consequences than benefits. Rather than endless patching this unintended consequences the design flaw should be rectified. The correct way to do this would seem to be to allow users to set a second name, which could be used as the primary display and organization name if they so choose, but keep the owner-set "real" name present and visible at all times.

[PVince81]

@NacreData how would that "second name" work ? Would the recipient see the folder twice, once with the original name and once with the renamed name ?

[PVince81]

If you'd like to discuss changing the design, feel free to post on http://central.owncloud.org/ so other people can also chime in and discuss whether this should be changed in the future.

[PVince81]

@davitol can you provide an integration test for this case ? Thanks