[master] sharing buttons are shown when sharing is disabled

[phil-davis]

Steps to reproduce

1. uncheck the Admin Sharing setting "Allow apps to use the Share API"
2. login as some user with files and folders
3. see and click the "sharing" icon for some file/folder

Expected behaviour

The sharing button is not even shown.
(this is what happens in stable10)

Actual behaviour

The sharing button is shown.
The sharing panel opens.
I can try and share with some user or group.
Then I get a message "Share API is disabled"

Server configuration

Operating system:
Ubuntu 18.04

Web server:
PHP dev server

Database:
MySQL

PHP version:
7.2

ownCloud version: (see ownCloud admin page)
current master

[phil-davis]

The test code in the master case finds the sharing panel, then types nothing in the share-with field. Of course nothing comes in the drop-down, and the test code decides that sharing is not possible. That is snake-oil. The test code should try to share with something that it knows exists (admin?) and get to the point where the message "Share API is disabled" is shown.

The scenario that does the weird stuff but passes is:

make test-acceptance-webui BEHAT_FEATURE=tests/acceptance/features/webUIRestrictSharing/disableSharing.feature:12

The webUI behavior is different in master. Is that supposed to be like that?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.