drone CleanupRemoteStoragesTest intermittent fail

[phil-davis]

We are getting an intermittent fail in drone PHPunit tests:
e.g.
https://drone.owncloud.com/owncloud/core/18820/209 stable10 with oracle DB

There was 1 failure:

1) OCA\Files_Sharing\Tests\Command\CleanupRemoteStoragesTest::testCleanup
Expectation failed for method name is equal to 'writeln' when invoked at sequence index 1
Parameter 0 for invocation Symfony\Component\Console\Output\OutputInterface::writeln('6 remote share(s) exist', 0) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'5 remote share(s) exist'
+'6 remote share(s) exist'

/drone/src/apps/files_sharing/lib/Command/CleanupRemoteStorages.php:67
/drone/src/apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php:183

I can run the unit test locally without error.

[phil-davis]

Other examples:
https://drone.owncloud.com/owncloud/core/18817/212 master MariaDB
https://drone.owncloud.com/owncloud/core/18813/137 master mysql
https://drone.owncloud.com/owncloud/core/18810/162 stable10 postgreSQL

and so on.

There seems to be no particular branch or database that causes the problem.

Some timing issue with that unit test case?

@micbar it is rather annoying for developers to get a CI pass. Who could look at this?

[phil-davis]

Demonstration in PR #35666

Example of the problem:
https://drone.owncloud.com/owncloud/core/18860/127

............................................................. 9150 / 9678 ( 94%)
.............................Farray(1) {
  [9]=>
  string(40) "shared::439de3b339c48d6c88064ac93a3615c4"
}
array(1) {
  [9]=>
  string(31) "shared::token6@http://localhost"
}
............................... 9211 / 9678 ( 95%)
............................................................. 9272 / 9678 ( 95%)
............................................................. 9333 / 9678 ( 96%)
............................................................. 9394 / 9678 ( 97%)
............................................................. 9455 / 9678 ( 97%)
............................................................. 9516 / 9678 ( 98%)
............................................................. 9577 / 9678 ( 98%)
............................................................. 9638 / 9678 ( 99%)
........................................                      9678 / 9678 (100%)

Time: 18.87 minutes, Memory: 4088.00MB

There was 1 failure:

1) OCA\Files_Sharing\Tests\External\ManagerTest::testReportLeftoverShareIds
there should be nothing in the share_external table but some share ids were found
Failed asserting that actual size 1 matches expected size 0.

/drone/src/apps/files_sharing/tests/External/ManagerTest.php:272

The previous testAddShareAccepted test case is leaving behind the token6 entry in the share_external table.

testAddShareAccepted was introduced in PR #35312

[phil-davis]

PRs #35665 and #35668 have changes for this issue. They are orthogonal. IMO both are a good thing to do.

[phil-davis]

Both PRs merged. Issue fixed.