Skip to content

allow . in dbname on web install - #10928

Merged
LukasReschke merged 1 commit into
masterfrom
allow_dot_in_dbname_on_web_install
Sep 9, 2014
Merged

allow . in dbname on web install#10928
LukasReschke merged 1 commit into
masterfrom
allow_dot_in_dbname_on_web_install

Conversation

@butonic

@butonic butonic commented Sep 8, 2014

Copy link
Copy Markdown
Contributor

Uses JS to update the dbname input pattern when switching databases in the installer. Removes the autoconfig workaround that is still necessary after merging #10694

@DeepDiver1975 @ser72 @VicDeo @cdamken @gig13 @craigpg

@butonic butonic added this to the 2014-sprint-03-current milestone Sep 8, 2014
@butonic butonic self-assigned this Sep 8, 2014
@scrutinizer-notifier

Copy link
Copy Markdown

A new inspection was created.

@ghost

ghost commented Sep 8, 2014

Copy link
Copy Markdown

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7134/

@karlitschek

Copy link
Copy Markdown
Contributor

makes sense 👍

@LukasReschke

Copy link
Copy Markdown
Contributor

What's the reason to have this in the JS instead in the template? (e.g.

pattern="[0-9a-zA-Z$_-]+" />
)

@butonic

butonic commented Sep 9, 2014

Copy link
Copy Markdown
Contributor Author

The pattern is different for oracle:
[0-9a-zA-Z$_-.]+ for oracle, because the dbname can contain dots
[0-9a-zA-Z$_-]+ for sane dbs

@butonic

butonic commented Sep 9, 2014

Copy link
Copy Markdown
Contributor Author

@LukasReschke

Copy link
Copy Markdown
Contributor

Thanks for the explanation. Then this makes indeed sense 👍

LukasReschke added a commit that referenced this pull request Sep 9, 2014
@LukasReschke
LukasReschke merged commit e9a3b28 into master Sep 9, 2014
@LukasReschke
LukasReschke deleted the allow_dot_in_dbname_on_web_install branch September 9, 2014 07:36
@LukasReschke

Copy link
Copy Markdown
Contributor

@karlitschek The referenced PR #10694 was backported to stable7. Shall we backport this as well?

@karlitschek

Copy link
Copy Markdown
Contributor

Yes please. We have bug reports here

@LukasReschke

Copy link
Copy Markdown
Contributor

Stable7: 5e5d9e0

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants