[master] Fix S3 connection regression#11721
Conversation
|
Seems the amazons3.php files are identical to stable7 (with this fix #11719) But still, on stable7 the unit tests pass but on master they fail. Let's merge this PR first then look into the failing unit tests. Please review @helmutschneider @butonic @LukasReschke |
|
The inspection completed: No new issues |
|
🚀 Test PASSed. 🚀 |
|
Unit test fix is here: #11726 (you can cherry pick it here first if you like) |
|
From a code point of view this makes totally sense. #11726 is now merged. I will test with this on top of latest master. |
|
Tested, code looks good 👍 |
|
Works. 👍 |
[master] Fix S3 connection regression
Fix for #11714 (master version)
Note that on master the unit tests were already broken.
Before fe912ca:
S..EEEEE...............................E...EE...E..EEEEEE.
On this branch:
S..EEEEE...............................E...EE...E..EEEEEE.