[WIP] read all relevant user attributes on login, in one query. saves us some. - #12943
Closed
blizzz wants to merge 1 commit into
Closed
[WIP] read all relevant user attributes on login, in one query. saves us some.#12943blizzz wants to merge 1 commit into
blizzz wants to merge 1 commit into
Conversation
|
The inspection completed: 11 new issues, 7 updated code elements |
Contributor
Member
|
needs rebase and in WIP state -> OC8.1 |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 159 lines...] > git config --local --remove-section credential # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git4683420848359394944.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse a6e7f67^{commit} # timeout=10Checking out Revision a6e7f67 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a6e7f67 > git rev-list 2b041b1 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEConfiguration pull-request-analyser-ng-simple » SLAVE is still in the queue: Waiting for next available executor on SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILURESetting status of a6e7f67 to FAILURE with url https://ci.owncloud.org/job/pull-request-analyser-ng-simple/12058/ and message: Build finished.💣 Test FAILed. 💣 |
Contributor
|
@blizzz is this oldie still valid ? |
Contributor
Author
|
With extending it also to user searches it would fix #17362 |
1 task
Contributor
Author
|
replaced by #18469 (too many changes in master since) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What has happened before:
What we do now:
I.e. in general this brings us performance improvements by less queries to the LDAP server. LDAP server will be happy, too, about less work. Helped with https://github.com/owncloud/enterprise/issues/442 in a OC 7 version (although it was not the root problem).
Also solves #12823
todos left