Skip to content

If no link text has been set for the navigation show the link nonetheless#14338

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-nav-heigt
Feb 19, 2015
Merged

If no link text has been set for the navigation show the link nonetheless#14338
MorrisJobke merged 1 commit into
masterfrom
fix-nav-heigt

Conversation

@BernhardPosselt

Copy link
Copy Markdown
Contributor

@jancborchardt

Copy link
Copy Markdown
Contributor

@steppenhahn also please test since you originally reported the issue at owncloud/notes#63

@Raydiation on pull requests please always mention the people who reported the original issue, thanks!

@ghost

ghost commented Feb 18, 2015

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9722/
Test PASSed.

@scrutinizer-notifier

Copy link
Copy Markdown

The inspection completed: No new issues

@jancborchardt

Copy link
Copy Markdown
Contributor

Nice, fixes the issue of empty entries not showing while not introducing any new issues. 👍

cc @owncloud/designers for another review as well.

@MorrisJobke

Copy link
Copy Markdown
Contributor

Works 👍

MorrisJobke added a commit that referenced this pull request Feb 19, 2015
If no link text has been set for the navigation show the link nonetheless
@MorrisJobke MorrisJobke merged commit 0e47d1f into master Feb 19, 2015
@MorrisJobke MorrisJobke deleted the fix-nav-heigt branch February 19, 2015 12:11
@MorrisJobke MorrisJobke added this to the 8.1-next milestone Feb 19, 2015
MorrisJobke added a commit that referenced this pull request Feb 19, 2015
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

able to create an "invisible" note

4 participants