Skip to content

remove duplicate ID in HTML template for public shares#17159

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-duplicate-id
Jul 2, 2015
Merged

remove duplicate ID in HTML template for public shares#17159
MorrisJobke merged 1 commit into
masterfrom
fix-duplicate-id

Conversation

@MorrisJobke

Copy link
Copy Markdown
Contributor
  • fixes itself
  • see line 80 for the other usage, which is actually use within the JS code.

cc @owncloud/designers

@karlitschek I would like to backport this to all stable branches, because it is invalid HTML (duplicate use of IDs is not allowed)

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

cc @PVince81 @nickvergessen

@scrutinizer-notifier

Copy link
Copy Markdown

A new inspection was created.

@PVince81

Copy link
Copy Markdown
Contributor

So I guess this element's id isn't used anywhere in JS code ?

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

So I guess this element's id isn't used anywhere in JS code ?

Yes. That is a simple link. But in the followup PR (#17160) I then used this ID.

@ghost

ghost commented Jun 25, 2015

Copy link
Copy Markdown

🚀 Test PASSed.🚀
chuck

@PVince81

Copy link
Copy Markdown
Contributor

Fine by me 👍

@DeepDiver1975 DeepDiver1975 added this to the 8.2-next milestone Jun 25, 2015
@DeepDiver1975

Copy link
Copy Markdown
Member

8.2 - by definition sev1 and sev2 are 8.1 - nothing else

@karlitschek

Copy link
Copy Markdown
Contributor

@MorrisJobke Backport is fine but we are in freeze for the stable releases at the moment. so please back port after the next releases are out

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

@MorrisJobke Backport is fine but we are in freeze for the stable releases at the moment. so please back port after the next releases are out

Will do that.

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

@rullzer @Xenopathic @Henni @ChristophWurst @LukasReschke Easy to review :)

@Henni

Henni commented Jul 2, 2015

Copy link
Copy Markdown
Contributor

👍 looks good to me

MorrisJobke added a commit that referenced this pull request Jul 2, 2015
remove duplicate ID in HTML template for public shares
@MorrisJobke MorrisJobke merged commit a3df41d into master Jul 2, 2015
@MorrisJobke MorrisJobke deleted the fix-duplicate-id branch July 2, 2015 15:50
MorrisJobke added a commit that referenced this pull request Jul 6, 2015
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants