Add indexes to speedup DB queries#17498
Merged
Merged
Conversation
* file_target is often used in the sharing code in JOIN statements for retrieval of shares
|
A new inspection was created. |
Contributor
Author
|
cc @carlaschroder for your information ;) |
Contributor
|
Great. I just talked with @bboule about this. |
Contributor
Author
|
@karlitschek Postgres and Oracle will be tested on CI nevertheless ;) |
Contributor
Author
|
ah yes. @bboule Feel free to comment on this |
Contributor
Author
And it additionally allows the DB server to handle more queries per second while reducing the load. (factor 10) |
|
🚀 Test PASSed.🚀 |
Contributor
|
👍 !!! |
Member
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jul 8, 2015
Add indexes to speedup DB queries
Contributor
|
Causes regression on mariadb: #17619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DeepDiver1975 @butonic @PVince81 @icewind1991 @schiesbn
Fixes #7474
We noticed that adding this two indexes reduced a lot of DB load.
I tested both with sqlite and mysql.