Properly nest groups when using memberOf to detect group membership, …

[GreenArchon]

…fixes #17759

[ghost]

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

[karlitschek]

@blizzz

[GreenArchon]

I hereby declare this diff MIT licensed

[LukasReschke]

@owncloud-bot This is okay to test.

[LukasReschke]

array &$seen?

[GreenArchon]

Please re-review.

Also, keep in mind this comment from #17759 :

• "This is not the best code I've written, as there's now 3 different functions in group_ldap that basically do the same thing (find elements based on attributes of a certain type on a DN), but they don't exactly return the same thing, and I didn't want to get into that for a quick bugfix"

[blizzz]

I think we can check for this setting before entering foreach uselessly and just return what we found.

[blizzz]

Looks good to me, especially with adjusted Tests! Only minor aspects to improve found. When they are done, 👍 from me.

Then we need another tester / reviewer, maybe @tps800 @ryno83 @davitol

[blizzz]

@karlitschek backport to 8.1 granted?

[karlitschek]

yes. please backport :-)

[scrutinizer-notifier]

A new inspection was created.

[GreenArchon]

@blizzz a55f233 is good for you?

[ghost]

🚀 Test PASSed.🚀

[PVince81]

@blizzz any update ? Merging this is blocking the 8.1.2 backport #18123

[MorrisJobke]

👍

[davitol]

👍 Tested with "version":"8.2.0.4","versionstring":"8.2 pre alpha"