Add command to get and set config for external mounts

[icewind1991]

Usage:

Currently this only works for admin configured storage due to limitations in the way we store mounts, with #20370 it can be extended to properly handle user configured mounts

cc @PVince81 @Xenopathic

[RobinMcCorkell]

Woah, nice! (Will review in the next few days)

[PVince81]

@icewind1991 can you always post a link to the original ticket it is related to ?

For #20368

[PVince81]

Looks good 👍

[RobinMcCorkell]

It would be cleaner to get if there is no value passed, and set if there is a value passed, removing the need for a separate command line argument.

Proposed example usage:

./occ files_external:config 42 host #prints 'localhost'
./occ files_external:config 42 host abc.example.com #sets host

[icewind1991]

Seems cleaner yes

[icewind1991]

Removed the get/set argument, action is now determined based on if the value is defined

[icewind1991]

Also added command to set mount options occ files_external:option which is used in the same way

[RobinMcCorkell]

The storage service will throw an exception itself if the storage cannot be found, so this block is unneeded (but it might be advisable to wrap the getStorage() in a try catch to print a better message)

[icewind1991]

Fixed

[RobinMcCorkell]

Return with a non-zero code so shell scripts can detect the error

[PVince81]

@icewind1991 can you fix this and then I'll count @Xenopathic's LGTM as 👍

[icewind1991]

done

[RobinMcCorkell]

LGTM so far, just one question: how can we set non-string values, e.g. integers or booleans?

[icewind1991]

You can just enter them directory, bools, ints and floats are all handled correctly

[PVince81]

@Xenopathic counts as 👍 ?

[icewind1991]

@Xenopathic @DeepDiver1975 merge?

[RobinMcCorkell]

@icewind1991 #20710 (comment)

[RobinMcCorkell]

👍