Filter getStorage to make sure the user has access to it#21468
Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @Xenopathic, @PVince81 and @LukasReschke to be potential reviewers |
Contributor
There was a problem hiding this comment.
New app in the making? 😆
icewind1991
force-pushed
the
getmount-id-filter
branch
from
2a49bba to
c8449bb
Compare
Contributor
Author
|
All fixed |
icewind1991
force-pushed
the
getmount-id-filter
branch
from
c8449bb to
f96492f
Compare
icewind1991
force-pushed
the
getmount-id-filter
branch
from
f96492f to
88bfe14
Compare
Contributor
Author
|
@LukasReschke @PVince81 @Xenopathic can this be merged? |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
I'd have used empty(), but it doesn't matter 😄
Contributor
|
Let's regression-test this. |
Contributor
|
Tested, ext storage scopes still works 👍 (had to merge #21467 to test non-admin user mount for system-wide storages) |
DeepDiver1975
added a commit
that referenced
this pull request
Jan 8, 2016
Filter getStorage to make sure the user has access to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the current storage service has access to the storage config we're trying to retrieve
Added test for it
cc @PVince81 @Xenopathic