Skip to content

Feature/20629 occ group commands#21627

Closed
edwardcrompton wants to merge 5 commits into
owncloud:masterfrom
edwardcrompton:feature/20629-occ-group-commands
Closed

Feature/20629 occ group commands#21627
edwardcrompton wants to merge 5 commits into
owncloud:masterfrom
edwardcrompton:feature/20629-occ-group-commands

Conversation

@edwardcrompton

Copy link
Copy Markdown
Contributor

Adding a console command for creating groups.

occ group:add

@mention-bot

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @nickvergessen, @schiesbn and @DeepDiver1975 to be potential reviewers

@karlitschek

Copy link
Copy Markdown
Contributor

@blizzz @PVince81 what do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGroupManager is undefined

@DeepDiver1975

Copy link
Copy Markdown
Member

Please squash your commits

@DeepDiver1975

Copy link
Copy Markdown
Member

@edwardcrompton Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check the return here.
If the return is false or null, it failed.

@DeepDiver1975 DeepDiver1975 added this to the 9.0-current milestone Jan 12, 2016
@blizzz

blizzz commented Jan 19, 2016

Copy link
Copy Markdown
Contributor

@edwardcrompton thanks for your contribution! To get this into ownCloud, could you check back with the things @DeepDiver1975 and @nickvergessen commented on?

@ghost

ghost commented Feb 21, 2016

Copy link
Copy Markdown

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@DeepDiver1975

Copy link
Copy Markdown
Member

Close due to inactivity

@lock

lock Bot commented Aug 7, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants