Add user provided auth mechanism

[icewind1991]

• requires External storage 'Login credentials' auth mechanism #18531

This adds an authentication option for admin defined mounts that require the user to enter the credentials on first use.

Currently the user can set his credentials in the personal settings, a nice dialog for entering the credentials if they are missing/wrong is to be added separately (iirc @jmaciasportela was going to work on that)

cc @PVince81 @Xenopathic @jmaciasportela

[mention-bot]

By analyzing the blame information on this pull request, we identified @MorrisJobke, @Xenopathic and @nickvergessen to be potential reviewers

[icewind1991]

Usage

1. Admin creates mount and selects user provided auth
2. Users sees mount with missing/invalid credentials
3. User enters his credentials in the personal settings
4. Mount is happy and works

[RobinMcCorkell]

I feel as though this is a really hacky way to implement this, with the separate controller, custom logic in the StoragesServices, and custom JS. I think a better way would be to leverage standard storage saving procedures, but have a way to define certain parameters as being user-modifyable, so they don't get greyed out in the settings area.

The whole point of the super-generic backend code was to avoid needing custom logic like this 🙊

[icewind1991]

Removed the custom controller and auth mechanism specific logic from the js.

the UserGlobalStoragesController now allows editing for storages that have an auth mechanism that implement IUserProvided, the auth mechanism can control what fields are visible for the user to edit (and hidden for the admin) by setting FLAG_USER_PROVIDED on the parameters

[RobinMcCorkell]

Some leftovers need to be removed

[icewind1991]

done

[RobinMcCorkell]

I like this a lot! Once the other PR is merged and this rebased, I'll review it

[PVince81]

@icewind1991 please rebase to include the changes from the other PR

[icewind1991]

rebased

[PVince81]

@icewind1991 please fix the failing JS unit tests

[PVince81]

• BUG: status indicator must be yellow, not red (just like for "login credentials")

[PVince81]

• BUG: edit the configuration several times, let it save, refresh the page: config duplicated

Steps:

1. Setup a SFTP mount
2. Select "User provided"
3. Type in host and path
4. Modify path once, exit field, wait for save
5. Modify path agin, exit field, wait for save
6. Refresh page

In all cases, the indicator was red and after refreshing the page, I had 3 SFTP configs.

[PVince81]

@icewind1991 please fix the bugs I mentionned above.
The status indicator is still red the first time instead of yellow.
After refreshing the page it becomes yellow, but the "config multiplication" issue is still there.

[PVince81]

• BUG: the mount point doesn't appear neither for SMB nor SFTP. Expected: the mount point must appear in the file list and be shown in red with the message "credentials required" (I know the dialog doesn't exist yet)

[PVince81]

Basically on my env it doesn't work like in your screenshots here #21790 (comment).
Even for SMB the status is red.

[PVince81]

IUserProvided instead of UserProvided ?

[icewind1991]

Also broken on master

[PVince81]

@icewind1991 please rebase, the master bug was merged

[PVince81]

@DeepDiver1975 all tests pass, re-review ?

[DeepDiver1975]

@icewind1991 you force pushed and killed my commit which cleaned up some use statments 👿

[PVince81]

@DeepDiver1975 you might be able to cherry-pick them from your local git branch

[DeepDiver1975]

@DeepDiver1975 you might be able to cherry-pick them from your local git branch

the changeset is not worth the effort - but the 'disrespect' in contribution is worth a discussion

[icewind1991]

Sorry, didn't see the commit while doing the rebasing

[PVince81]

@DeepDiver1975 I also tend to rebase+force push often as it seldom happens that people push on my branches, easy to be overlooked. When pushing it's best to also post a comment to say so to make sure the PR owner gets a notification. I also didn't see your commit 😦

Let's be more careful in the future.

[PVince81]

@DeepDiver1975 any remaining objections to merging this PR ?

[DeepDiver1975]

@DeepDiver1975 any remaining objections to merging this PR ?

no

👍

[DeepDiver1975]

needs rebase - conflict in setting.js

[PVince81]

Noooooooooooooooooooooh. @icewind1991 ?