Introduce autotest.sh for LDAP integrations tests, a minor fix and some …#23832
Closed
blizzz wants to merge 10 commits into
Closed
Introduce autotest.sh for LDAP integrations tests, a minor fix and some …#23832blizzz wants to merge 10 commits into
blizzz wants to merge 10 commits into
Conversation
|
By analyzing the blame information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @LukasReschke to be potential reviewers |
blizzz
changed the title
Contributor
|
Contributor
Author
|
@MorrisJobke see the readme file: |
Contributor
🙈 |
Member
|
@blizzz I like this - I'm willing to setup this on jenkins as soon as this is fully automated by running one script. |
Contributor
Author
|
@DeepDiver1975 Roger, I'll tune autotest.sh to get the additional files and create a default config
|
blizzz
force-pushed
the
ldap-integration-tests-1up
branch
from
April 26, 2016 06:52
29af179 to
a51b23f
Compare
Contributor
Author
|
@DeepDiver1975 @MorrisJobke please have a fresh look. Requires wget to fetch files. |
Contributor
|
Funny ... it starts a lot of containers, prints no errors but also doesn't list any tests. The return value is 0. |
Contributor
|
Is this intended?
Edit blizzz: checkbox |
Contributor
Author
|
No, that's strange, I give it another look. |
Contributor
owncloud/administration#75 This makes the output less verbose and errors are still shown. |
Contributor
|
Contributor
Author
which errors are shown? I silenced it down some more, including wget, for me it now looks like: Mind to retry? P.S.: i have it also successfully running on a Debian 8.4 VM with 4.5 Linux kernel. |
Contributor
I just tested with a mistyped image name. So no error during the autotest.sh run. Maybe its because I use a non-conventional setup, where the ports are not forwarded to localhost, but the VM, where the docker is running. (on OS X I need to use this) But the output looks weird: Maybe the error handling needs to be improved |
Contributor
Author
|
@MorrisJobke that's still not how it should look like. Compare with my output. |
Contributor
Contributor
Author
Ah… well, well, I did not get a single commit inside that file 👅 ;) |
Contributor
Ah ... it was Vincent :D No worries :) I managed to fix it. |
Contributor
Author
|
I did not retest yet, but as far as i can see basically needs to be dealt with. |
Contributor
|
Needs rebase. Massive conflicts due to the move to PSR-4 😦 CC @nickvergessen if you can help somehow |
Contributor
|
I can try to do the rebase, but as far as I can see, there are still open comments. |
It might be just as well, that ownCloud caught an error making php exit with 0.
nickvergessen
force-pushed
the
ldap-integration-tests-1up
branch
from
June 13, 2016 11:23
b4c6c52 to
97cf381
Compare
Contributor
|
Rebased (without addressing additional comments) |
Contributor
|
Moving this to 9.2 |
Contributor
|
@DeepDiver1975 something to move and reuse in the user_ldap repo ? |
Contributor
|
@jvillafanez move to the ldap repo ? |
Member
|
Move to owncloud/user_ldap#17 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cleanup
I just run this as root (because docker):
It would stop after the first test that fails.
@DeepDiver1975 @MorrisJobke