Move logout to controller#24056
Merged
Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @bartv2, @MorrisJobke and @jakobsack to be potential reviewers |
| ['name' => 'avatar#getTmpAvatar', 'url' => '/avatar/tmp', 'verb' => 'GET'], | ||
| ['name' => 'avatar#postAvatar', 'url' => '/avatar/', 'verb' => 'POST'], | ||
| ['name' => 'login#showLoginForm', 'url' => '/login', 'verb' => 'GET'], | ||
| ['name' => 'login#logout', 'url' => '/logout', 'verb' => 'GET'], |
Contributor
|
@LukasReschke I noticed #24057 while testing this. Maybe @DeepDiver1975 could comment on this. |
Testable code. Yay.
LukasReschke
force-pushed
the
move-logout-to-logincontroller
branch
from
April 18, 2016 19:22
08f0f2c to
8222ad5
Compare
Contributor
|
Testable code!!! 👯 |
Contributor
This is addressed in a separate PR. 👍 for this PR |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testable code. Yay.
cc @blizzz @rullzer