Skip to content

Add a warning if a storage wrapper was registered outside of the hook#24335

Merged
DeepDiver1975 merged 1 commit into
masterfrom
warning-for-wrongly-done-storage-wrappers
Apr 29, 2016
Merged

Add a warning if a storage wrapper was registered outside of the hook#24335
DeepDiver1975 merged 1 commit into
masterfrom
warning-for-wrongly-done-storage-wrappers

Conversation

@nickvergessen

Copy link
Copy Markdown
Contributor

@rullzer

rullzer commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

I like it!
Is it possible to have tests?

@nickvergessen

Copy link
Copy Markdown
Contributor Author

Is it possible to have tests?

well it's all static and it only creates a log entry, not sure if that is suitable for writing a useful test

@icewind1991

Copy link
Copy Markdown
Contributor

👍 good to have

@rullzer

rullzer commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

👍

@DeepDiver1975
DeepDiver1975 merged commit 6c2e94e into master Apr 29, 2016
@DeepDiver1975
DeepDiver1975 deleted the warning-for-wrongly-done-storage-wrappers branch April 29, 2016 15:43
@lock

lock Bot commented Aug 6, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not wrap storage of owner anymore

4 participants