Skip to content

decrease initial users to load to 50 - #24999

Merged
PVince81 merged 1 commit into
masterfrom
initial-userloading-workaround
Jun 8, 2016
Merged

decrease initial users to load to 50#24999
PVince81 merged 1 commit into
masterfrom
initial-userloading-workaround

Conversation

@butonic

@butonic butonic commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Prevents timeouts on the initial loading of users. proper fix will be in #10994
Workaround for #24734

@DeepDiver1975 @PVince81 Should be backported to 9.0.3

Prevents timeouts on the initial loading of users. proper fix will be in #10994
Workaround for #24734
@mention-bot

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers

@PVince81

PVince81 commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

As discussed 👍

@PVince81

PVince81 commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

@nickvergessen second review ?

@nickvergessen

Copy link
Copy Markdown
Contributor

👍 I hope we have no JS test that checks this value 😛

@guruz

guruz commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Would be cool if commit subject lines had an identifying prefix.
In the client we do things like "SyncEngine: fix mem leak" or "Toolbar: fix mem leak" or whatever. Then it's easier to identify what this is about.
Here I thought it was an LDAP issue or so.

@nickvergessen

Copy link
Copy Markdown
Contributor

Well we use the light blue and purple labels for that ;)

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Jun 7, 2016
@DeepDiver1975

Copy link
Copy Markdown
Member

Nice!

@DeepDiver1975

Copy link
Copy Markdown
Member

@DeepDiver1975 @PVince81 Should be backported to 9.0.3

please submit backport pr - thx

@DeepDiver1975

Copy link
Copy Markdown
Member

@PVince81 if I remember correctly we had issues in the past with the scrolling functionality if the initial set was to small. Has this been addressed / tested?

@PVince81

PVince81 commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

@DeepDiver1975 I haven't retested this, but note that we already had the small value in all past versions. I believe @butonic increased it to improve UX and avoid having the user scroll, wait, scroll, wait too often.

@georgehrke

Copy link
Copy Markdown
Contributor

👍

@butonic

butonic commented Jun 7, 2016

Copy link
Copy Markdown
Contributor Author

I increased the initial number of users to 250 because we saw a complaint about having to scroll to reach a user ... well there is user search anyway. maybe increasing subsequent user fetches from 10 to 30 eases the pain a little?

@PVince81
PVince81 merged commit 111b4d7 into master Jun 8, 2016
@PVince81
PVince81 deleted the initial-userloading-workaround branch June 8, 2016 08:12
@PVince81

Copy link
Copy Markdown
Contributor

stable9: #25105

@lock

lock Bot commented Aug 5, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants