Use capped cache for encryption's user access list

[PVince81]

For #24403 (comment)

@owncloud/filesystem @owncloud/encryption @butonic @mmattel @nickvergessen @rullzer

[mention-bot]

By analyzing the blame information on this pull request, we identified @schiessle, @DeepDiver1975 and @LukasReschke to be potential reviewers

[guruz]

semi- 👍

Where was the (non capped?) $this->cache initialized before? In some sub class?

Does it make sense to construct it lazily only in getAccessList() ?

[PVince81]

Where was the (non capped?) $this->cache initialized before? In some sub class?

It wasn't. It's PHP magic 🔮

This is valid PHP:

<?php
$x = null;
$x[] = 1;

I don't think there is much benefit to construct it lazily especially that this here is just a utility class instantiated once.

[PVince81]

This is valid PHP:

I tested that locally and couldn't believe my eyes...

[butonic]

👍

[nickvergessen]

Not even needed to $x = null: https://3v4l.org/vC6gF

[PVince81]

stable9: #25084

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.