Convert Dropbox Forbidden exception to StorageNotAvailableException

[PVince81]

Fixes #24739

Basically Dropbox's Forbidden exception is almost always about an error in the request, server error or rate limit error, never something about the files directly. So we can assume that it's about the server not being available temporarily and convert it to StorageNotAvailableException.

This prevents the bad code path that returns false and makes the caller think that the file/folder does not exist any more (false positive).

Please review @owncloud/filesystem @faulix

Would be good to backport this to 9.0 and maybe 8.2 too @DeepDiver1975 @dragotin

[mention-bot]

By analyzing the blame information on this pull request, we identified @MTGap, @icewind1991, @butonic and @Xenopathic to be potential reviewers

[faulix]

I'm testing it now. For backporting (I use 9.0.2) you need to do the following changes in apps/files_external/lib/dropbox.php:

• Line 30: namespace OCA\Files_External\Lib\Storage; -> namespace OC\Files\Storage;
• Line 37: require_once __DIR__ . '/../../../3rdparty/Dropbox/autoload.php'; -> require_once __DIR__ . '/../3rdparty/Dropbox/autoload.php';

I will report if something doesn't work.

[guruz]

Code and logic looks fine 👍

I checked the Google Drive storage to see if we need to do the same there. I guess not because it will just rethrow any exception which should be OK then..

[PVince81]

@icewind1991 second review ?

[icewind1991]

👍 looks good

[PVince81]

stable9: #25148

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.