Skip to content

load authentication apps first - #25126

Merged
DeepDiver1975 merged 2 commits into
masterfrom
ocs-load-auth-apps-first
Jun 16, 2016
Merged

load authentication apps first#25126
DeepDiver1975 merged 2 commits into
masterfrom
ocs-load-auth-apps-first

Conversation

@ChristophWurst

Copy link
Copy Markdown
Contributor

fixes https://github.com/owncloud/mail/issues/1422

This fixes a problem of the mail app where code in app.php uses the user manager to get a user. The user manager then asks the registered user backends. However, as mail is loaded before user_ldap, the ldap backend has not been loaded yet 💥

@DeepDiver1975 as discussed

cc @blizzz @MorrisJobke @LukasReschke @Gomez

@mention-bot

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @bartv2 and @PVince81 to be potential reviewers

@DeepDiver1975

Copy link
Copy Markdown
Member

👍

@ChristophWurst please submit prs for all stable branches down to stable8

@blizzz

blizzz commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

Good catch! Isn't it also necessary to load session (before) filesystem and logging (both afterwards) types seperately as well?

@nickvergessen

Copy link
Copy Markdown
Contributor

👍

@ChristophWurst

Copy link
Copy Markdown
Contributor Author

Good catch! Isn't it also necessary to load session (before) filesystem and logging (both afterwards) types seperately as well?

@DeepDiver1975 should I change that order too?

@DeepDiver1975

Copy link
Copy Markdown
Member

Yes please @blizzz is totally right.

@ChristophWurst

Copy link
Copy Markdown
Contributor Author

@blizzz @DeepDiver1975 now session apps are loaded before authentication before all other apps. That is exactly what base.php does for logged in users. Please re-review

@nickvergessen

Copy link
Copy Markdown
Contributor

👍

@MorrisJobke

Copy link
Copy Markdown
Contributor

I tested this with the mail app and LDAP and it works after applying this patch :)

Thanks 👍

@lock

lock Bot commented Aug 5, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants