Skip to content

fixes #18971#25426

Closed
cyberb wants to merge 1 commit into
owncloud:masterfrom
cyberb:master
Closed

fixes #18971#25426
cyberb wants to merge 1 commit into
owncloud:masterfrom
cyberb:master

Conversation

@cyberb

@cyberb cyberb commented Jul 9, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

Copy link
Copy Markdown

@cyberb, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @DeepDiver1975 and @PVince81 to be potential reviewers

@ghost

ghost commented Jul 10, 2016

Copy link
Copy Markdown

@cyberb

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@cyberb

cyberb commented Jul 10, 2016

Copy link
Copy Markdown
Contributor Author

This contribution is MIT licensed

@icewind1991

Copy link
Copy Markdown
Contributor

This workaround should only be used on system where it's actually needed (32bit systems)

@cyberb

cyberb commented Jul 10, 2016

Copy link
Copy Markdown
Contributor Author

I can do another PR, but I am not sure why would you use two different implementations if one covers all the cases.

@cyberb

cyberb commented Jul 10, 2016

Copy link
Copy Markdown
Contributor Author

just in case you really want 32bit only fix, here is another PR: #25428

@DeepDiver1975

Copy link
Copy Markdown
Member

I can do another PR, but I am not sure why would you use two different implementations if one covers all the cases.

forking another process has an impact on performance - I prefer to go with #25428

@lock

lock Bot commented Aug 5, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants