Skip to content

[9.2] Sync deathdate and anniversary to birthday calendar #25655

Merged
DeepDiver1975 merged 2 commits into
masterfrom
sync-date-of-death
Sep 30, 2016
Merged

[9.2] Sync deathdate and anniversary to birthday calendar #25655
DeepDiver1975 merged 2 commits into
masterfrom
sync-date-of-death

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Jul 29, 2016

Copy link
Copy Markdown
Member

In addition to the birthday also deathdate and anniversary are synced to the calendar

bildschirmfoto von 2016-07-29 16-16-09
bildschirmfoto von 2016-07-29 16-15-38

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Jul 29, 2016
@mention-bot

mention-bot commented Jul 29, 2016

Copy link
Copy Markdown

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Garfonso, @LukasReschke, @nickvergessen and @DeepDiver1975 to be potential reviewers

@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 29, 2016
Merged
@PVince81

PVince81 commented Aug 16, 2016

Copy link
Copy Markdown
Contributor 
20:59:25 1) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #0 (true, null)
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 2) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #1 (true, '')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 3) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #2 (true, 'yasfewf')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 4) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #3 (true, 'BEGIN:VCARD\nVERSION:3.0\nPRODI...VCARD\n', 'Dr. Foo Bar')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 5) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #4 (true, 'BEGIN:VCARD\nVERSION:3.0\nPRODI...VCARD\n', 'Dr. Foo Bar')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 6) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #5 (true, 'BEGIN:VCARD\nVERSION:3.0\nPRODI...VCARD\n', 'Dr. Foo Bar')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 7) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testBuildBirthdayFromContact with data set #6 (false, 'BEGIN:VCARD\nVERSION:3.0\nPRODI...VCARD\n', 'Dr. Foo Bar')
20:59:25 Missing argument 2 for OCA\DAV\CalDAV\BirthdayService::buildDateFromContact(), called in /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php on line 60 and defined
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:115
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:60
20:59:25 
20:59:25 --
20:59:25 
20:59:25 There were 4 failures:
20:59:25 
20:59:25 1) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testOnCardDeleted
20:59:25 OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject(1234, 'default-gump.vcf.ics-death') was not expected to be called more than once.
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:86
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:87
20:59:25 
20:59:25 2) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testOnCardChanged with data set #0 ('delete')
20:59:25 OCA\DAV\CalDAV\CalDavBackend::getCalendarObject(1234, 'default-gump.vcf-death.ics') was not expected to be called more than once.
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:232
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:69
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:128
20:59:25 
20:59:25 3) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testOnCardChanged with data set #1 ('create')
20:59:25 Expectation failed for method name is equal to <string:createCalendarObject> when invoked 1 time(s).
20:59:25 Method was expected to be called 1 times, actually called 0 times.
20:59:25 
20:59:25 4) OCA\DAV\Tests\unit\CardDAV\BirthdayServiceTest::testOnCardChanged with data set #2 ('update')
20:59:25 OCA\DAV\CalDAV\CalDavBackend::getCalendarObject(1234, 'default-gump.vcf-death.ics') was not expected to be called more than once.
20:59:25 
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:232
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/lib/CalDAV/BirthdayService.php:69
20:59:25 /var/lib/jenkins/workspace/owncloud-core/core/PR-25655/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php:128

@DeepDiver1975

DeepDiver1975 commented Aug 25, 2016

Copy link
Copy Markdown
Member Author

Needs rebase

@DeepDiver1975 DeepDiver1975 force-pushed the sync-date-of-death branch 2 times, most recently from 92dcbcd to e48f5f6 Compare August 29, 2016 07:12
@DeepDiver1975 DeepDiver1975 force-pushed the sync-date-of-death branch 2 times, most recently from 59ac17e to d87d24e Compare September 7, 2016 19:10
@butonic

butonic commented Sep 27, 2016

Copy link
Copy Markdown
Contributor

rename BirthdayService.php to ContactsService because it is no longer about Birthdates only?

@butonic

butonic commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

👍

@DeepDiver1975 DeepDiver1975 merged commit 5833c24 into master Sep 30, 2016
@DeepDiver1975 DeepDiver1975 deleted the sync-date-of-death branch September 30, 2016 08:29
@rullzer rullzer mentioned this pull request Oct 14, 2016
Merged
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @mention-bot @PVince81 @butonic