[stable9] add conditional smb trace logging for debug purposes#25808
Merged
Conversation
|
@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @jvillafanez, @jmaciasportela and @Xenopathic to be potential reviewers |
butonic
changed the title
Member
|
I don't know why it isn't, but the rename method should be there. |
Member
I'll delegate the answer to the implementation in 8.2 😄 . Anyway, the custom method will improve the performance over the default "copy-and-remove" one. |
Member
|
Anyway 👍 for this PR |
Contributor
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #25758
One difference I see to master is the missing rename method. But I'll leave it for a separate PR. @jvillafanez I think it was added because smb does not overwrite existing folders?
cc @dercorn @DeepDiver1975