Added testcases about adding and removing users to groups using subad…#25809
Conversation
|
@SergioBertolinSG, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @LukasReschke and @DeepDiver1975 to be potential reviewers |
| And user "subadmin" exists | ||
| And user "brand-new-user" exists | ||
| And group "new-group" exists | ||
| And Assure user "subadmin" is subadmin of group "new-group" |
There was a problem hiding this comment.
not sure why we need the word "Assure" here as all commands we give here are about assuring 😄
There was a problem hiding this comment.
Well, that is because there are two situations, one where you just want to check something, like in when statements and one when you want to check it and modify something to make it be that way.
|
Looks good, thanks a lot! 👍 |
|
@PVince81 After reading your review I've realized I was adding users to groups in the final then statements. I think we should differenciate assure and check functions in every step to have it clear. 'Assure' checks and makes a modification, good for given statements and 'Check' only checks the current status, good for then statements. I understand it is a bit confusing at the moment as we don't have it explicit in every statement. |
|
@DeepDiver1975 if only OCI fails, does it mean the integration tests at least passed ? Or is there a risk that they didn't ? (I don't want to read the full log) We might want to increate the OCI timeout, or even more OCI to a separate job to avoid confusion and make it easier to ignore. |
|
Perhaps adding a job only running integration tests? It was useful before. |
|
@SergioBertolinSG the new tests, (or the new Jenkins server?) at some point, should output a results matrix even from a single execution. |
|
Job execution is sequential. Click on the pr on Jenkins and you will get an overview over all Jobs which got executed ob this pr. |
|
Looks like the Oracle Docker did not Start within 2h |
Ah! That's the page I was looking for. Basically open the log URL and remove the suffix: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-25809 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
…mins
please review @PVince81