Conversation
|
@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Xenopathic, @PVince81 and @icewind1991 to be potential reviewers |
Contributor
|
Weird, but my local tests worked ?! |
Contributor
|
👍 |
Member
|
🚑 👍 |
Contributor
|
@butonic what about stable9 ? |
Contributor
|
to answer my question, a fix has been pushed on the existing PR #25843 |
Contributor
|
this wasn't discovered by CI and likely won't either. A local run of ./autotest-external.sh which covers some cases didn't show any failures. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a bug introduced with #25845
cc @PVince81 @jvillafanez I will look for a test case to cover this in a separate PR